Skip to content

Conversation

@Doc94
Copy link
Member

@Doc94 Doc94 commented Oct 3, 2025

Adds the reason for spawn de Copper Golem from a Statue, the name of the reason its based in
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/2ffa847835b0d2d7f85bccbb6951e819374e13a6

@Doc94 Doc94 requested a review from a team as a code owner October 3, 2025 00:51
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Oct 3, 2025
@jpenilla
Copy link
Member

jpenilla commented Oct 3, 2025

see #13118 for previous comments

@Doc94
Copy link
Member Author

Doc94 commented Oct 3, 2025

@lynxplay

Uncertain if we need to delay the block removal / move up the addLivingEntity bit this far.

While building golems generally respect the spawn event cancel for block removal, plain block -> entity bits like frog spawn, dried ghast or turtle egg do not.

hmm ok i can change that i think, i add a apinote in the reason for notice that behaviour related to the block

@github-project-automation github-project-automation bot moved this from Awaiting review to Changes required in Paper PR Queue Oct 17, 2025
Doc94 and others added 2 commits October 17, 2025 21:07
Co-authored-by: Jason Penilla <[email protected]>
Co-authored-by: Jason Penilla <[email protected]>
@jpenilla
Copy link
Member

looks like build failed for some reason (javadoc failure)

@Doc94
Copy link
Member Author

Doc94 commented Oct 18, 2025

looks like build failed for some reason (javadoc failure)

Yep its the javadoc.io again :/

@electronicboy
Copy link
Member

transient, rebuild worked

@jpenilla jpenilla merged commit 1e67ca8 into PaperMC:main Oct 18, 2025
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Changes required to Merged in Paper PR Queue Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants